linux-kernel - Re: [PATCH 2/2] drm/amd/display: Don't build DCN1 when kcov is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0Ds9OPqDqpBeY_cbQShTCO9Bkf4uRBtpAz4+8RP2Mwaw@mail.gmail.com>
Date:   Thu, 16 Aug 2018 23:05:51 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     sunpeng.li@....com
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        michel.daenzer@....com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        amd-gfx@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        Jordan Lazare <Jordan.Lazare@....com>,
        Harry Wentland <harry.wentland@....com>
Subject: Re: [PATCH 2/2] drm/amd/display: Don't build DCN1 when kcov is enabled

On Thu, Aug 16, 2018 at 9:45 PM <sunpeng.li@....com> wrote:
>
> From: "Leo (Sunpeng) Li" <sunpeng.li@....com>
>
> DCN1 contains code that utilizes fp math. When
> CONFIG_KCOV_INSTRUMENT_ALL and CONFIG_KCOV_ENABLE_COMPARISONS are
> enabled, build errors are found. See this earlier patch for details:
>
> https://lists.freedesktop.org/archives/dri-devel/2018-August/186131.html
>
> As a short term solution, disable CONFIG_DRM_AMD_DC_DCN1_0 when
> KCOV_INSTRUMENT_ALL and KCOV_ENABLE_COMPARISONS are enabled. In
> addition, make it a fully derived config, taking into account
> CONFIG_X86.
>
> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@....com>

Looks good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>