linux-kernel - Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43da98d0-409b-88b9-0178-a79b581fc044@linux.com>
Date:   Fri, 17 Aug 2018 01:18:10 +0300
From:   Alexander Popov <alex.popov@...ux.com>
To:     Kees Cook <keescook@...omium.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Ingo Molnar <mingo@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tycho Andersen <tycho@...ho.ws>,
        Mark Rutland <mark.rutland@....com>,
        Laura Abbott <labbott@...hat.com>,
        Will Deacon <will.deacon@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-crypto <linux-crypto@...r.kernel.org>
Subject: Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

Hello,

On 15.08.2018 23:56, Kees Cook wrote:
> On Wed, Aug 15, 2018 at 1:18 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>> I absolutely refuse to take any hardening patches at all that have
>> BUG() or panic() or similar machine-killing in it.
> 
> Okay, mental model adjusted. :) It was only "strong discouraged" until now.
> 
>> I thought VLA's were mostly gone.
...
> And after that, there's a single patch to move -Wvla up into the
> top-level Makefile:
> 
> https://patchwork.kernel.org/patch/10489873/
> 
> So, we're basically done

I've just sent the 15th version of the series with changes according to the
feedback from Linus:

1. BUG_ON() in stackleak_erase() is safely eliminated;

2. Stack Clash detection (alloca() check) is completely dropped, since global
'-Wvla' should arrive soon. stackleak_check_alloca() for arm64 is dropped as
well in a separate commit.

This version is rebased onto Linus' tree.

Best regards,
Alexander