linux-kernel - Re: [PATCH v2 3/4] mm/memory_hotplug: Make register_mem_sect_under_node a cb of walk_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180816061552.GA15875@techadventures.net>
Date:   Thu, 16 Aug 2018 08:15:52 +0200
From:   Oscar Salvador <osalvador@...hadventures.net>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     mhocko@...e.com, vbabka@...e.cz, pavel.tatashin@...rosoft.com,
        Jonathan.Cameron@...wei.com, arbab@...ux.vnet.ibm.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH v2 3/4] mm/memory_hotplug: Make
 register_mem_sect_under_node a cb of walk_memory_range

On Wed, Aug 15, 2018 at 03:21:35PM -0700, Andrew Morton wrote:
> On Fri, 22 Jun 2018 13:18:38 +0200 osalvador@...hadventures.net wrote:
> 
> > From: Oscar Salvador <osalvador@...e.de>
> > 
> > link_mem_sections() and walk_memory_range() share most of the code,
> > so we can use convert link_mem_sections() into a dummy function that calls
> > walk_memory_range() with a callback to register_mem_sect_under_node().
> > 
> > This patch converts register_mem_sect_under_node() in order to
> > match a walk_memory_range's callback, getting rid of the
> > check_nid argument and checking instead if the system is still
> > boothing, since we only have to check for the nid if the system
> > is in such state.
> > 
> > Signed-off-by: Oscar Salvador <osalvador@...e.de>
> > Suggested-by: Pavel Tatashin <pasha.tatashin@...cle.com>
> 
> We have two tested-by's bu no reviewers or ackers?
 
Pavel, would you be so kind to review this patch?
It is the only patch from the patchset which did not get a 
review.

Thanks!
-- 
Oscar Salvador
SUSE L3