linux-kernel - Query on shrink list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org>
Date:   Fri, 17 Aug 2018 15:39:22 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Al Viro <viro@...IV.linux.org.uk>, linux-fsdevel@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>
Subject: Query on shrink list

Hi Al Viro,

Is there is reason we have kept data->found++, if the dentry already 
there in shrink list ?

static enum d_walk_ret select_collect(
...
         if (dentry->d_flags & DCACHE_SHRINK_LIST) {
                 data->found++;
         } else {
   ..

If the dentry is already there on shrink list, does it not mean that 
data->found is already non-zero ?
Can't we just go out from here directly?

Regards,
Mukesh