linux-kernel - Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfeLf39vVd37W=2V-fJiSs=5zoKMxYS2g4o_mTn3GBjiQ@mail.gmail.com>
Date:   Fri, 17 Aug 2018 14:27:57 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     "Lee, Chun-Yi" <jlee@...e.com>, Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit

On Fri, Aug 17, 2018 at 2:22 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
> On Fri, 2018-08-17 at 14:09 +0300, Andy Shevchenko wrote:
>> On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko
>> <andy.shevchenko@...il.com> wrote:
>> > On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
>> > <benh@...nel.crashing.org> wrote:
>> > > This driver prints that "Unsupported machine..." message on every boot on
>> > > ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
>> > > causes graphical boots to "glitch" a bit and is rather annoying ...
>> > >
>> > > Make it a pr_debug instead.
>> >
>> > Thanks for the patch. Unfortunately it doesn't apply.
>> > Please, check your mail clients and tools for formatting patch (it
>> > produced at the end spaces instead of tabs)
>>
>> No need to resend _this_ time. I have pushed to my review and testing queue.
>
> Thanks, odd. Not sure what's going on with the latest evolution, it's
> the second time it's done this. I'll try to investigate. Small patch
> like that I tend to just copy/paste in an email in "preformat" style
> ;-)

Evolution is totally broken for years already (yes, I'm still using it
due to Outlook Web Services support, but it's utter PITA).
I could just easily come up with couple of dozens of bugs that are
present there for more than 3 years.

>
> Cheers,
> Ben.
>>
>> > >
>> > > Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> > > ---
>> > >
>> > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> > > index 8952173dd380..7f7192e8fdab 100644
>> > > --- a/drivers/platform/x86/acer-wmi.c
>> > > +++ b/drivers/platform/x86/acer-wmi.c
>> > > @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
>> > >         if (wmi_has_guid(AMW0_GUID1) &&
>> > >             !dmi_check_system(amw0_whitelist) &&
>> > >             quirks == &quirk_unknown) {
>> > > -               pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
>> > > +               pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
>> > >                 return -ENODEV;
>> > >         }
>> > >
>> > >
>> >
>> >
>> >
>> > --
>> > With Best Regards,
>> > Andy Shevchenko
>>
>>
>>
>



-- 
With Best Regards,
Andy Shevchenko