linux-kernel - Re: [PATCH] media: NULL check is meaningless before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B76BDD8.9040203@huawei.com>
Date:   Fri, 17 Aug 2018 20:21:44 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:     <mchehab@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: NULL check is meaningless before debugfs_remove_recursive

On 2018/8/17 17:18, Laurent Pinchart wrote:
> Hi Zhong,
>
> Thank you for the patch.
>
> On Friday, 17 August 2018 06:37:26 EEST zhong jiang wrote:
>> debugfs_remove_recursive has taken null pointer into account. so
>> remove the unneeded check.
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> I already have a similar patch in my tree (git://linuxtv.org/pinchartl/
> media.git uvc/next) and will include it in my pull request for v4.20.
  Thank you for let me know that. Maybe I miss that.

 Sincerely,
 zhong jiang
>> ---
>>  drivers/media/usb/uvc/uvc_debugfs.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/usb/uvc/uvc_debugfs.c
>> b/drivers/media/usb/uvc/uvc_debugfs.c index 368f8f8..6995aeb 100644
>> --- a/drivers/media/usb/uvc/uvc_debugfs.c
>> +++ b/drivers/media/usb/uvc/uvc_debugfs.c
>> @@ -128,6 +128,5 @@ void uvc_debugfs_init(void)
>>
>>  void uvc_debugfs_cleanup(void)
>>  {
>> -	if (uvc_debugfs_root_dir != NULL)
>> -		debugfs_remove_recursive(uvc_debugfs_root_dir);
>> +	debugfs_remove_recursive(uvc_debugfs_root_dir);
>>  }