linux-kernel - Re: [PATCH 7/7] gpio: ingenic: Remove driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180817150957.GE20845@rob-hp-laptop>
Date:   Fri, 17 Aug 2018 09:09:57 -0600
From:   Rob Herring <robh@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Paul Cercueil <paul@...pouillou.net>
Subject: Re: [PATCH 7/7] gpio: ingenic: Remove driver

Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.

On Thu, 16 Aug 2018 18:35:44 +0200, Paul Cercueil wrote:
> The pinctrl-ingenic driver is now handling the GPIO chips directly.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>

The preferred subject prefix is "dt-bindings: <binding dir>: ...".

> ---
>  .../devicetree/bindings/gpio/ingenic,gpio.txt      |  46 ---
>  drivers/gpio/Kconfig                               |  11 -
>  drivers/gpio/Makefile                              |   1 -
>  drivers/gpio/gpio-ingenic.c                        | 392 ---------------------
>  4 files changed, 450 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/gpio/ingenic,gpio.txt
>  delete mode 100644 drivers/gpio/gpio-ingenic.c
> 

DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.