linux-kernel - Re: [PATCH] drviers: intel_ips: remove the unneeded null pointer check before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B764655.7000803@huawei.com>
Date:   Fri, 17 Aug 2018 11:51:49 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <dvhart@...radead.org>, <andy@...radead.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drviers: intel_ips: remove the unneeded null pointer
 check before debugfs_remove_recursive

subect:  drviers/drivers   will repost, please ingore the patch. Thanks
On 2018/8/17 11:31, zhong jiang wrote:
> debugfs_remove_recursive has taken the null pointer into account.
> just remove the null check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/platform/x86/intel_ips.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index c5ece7e..1c3127c 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1311,8 +1311,7 @@ static int ips_debugfs_open(struct inode *inode, struct file *file)
>  
>  static void ips_debugfs_cleanup(struct ips_driver *ips)
>  {
> -	if (ips->debug_root)
> -		debugfs_remove_recursive(ips->debug_root);
> +	debugfs_remove_recursive(ips->debug_root);
>  	return;
>  }
>