linux-kernel - Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23e2d972-c1fd-4581-60d1-a3a736f311a8@grimberg.me>
Date:   Fri, 17 Aug 2018 15:47:04 -0700
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Bart Van Assche <Bart.VanAssche@....com>, "hch@....de" <hch@....de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "hare@...e.de" <hare@...e.de>, "axboe@...nel.dk" <axboe@...nel.dk>,
        "hare@...e.com" <hare@...e.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "keith.busch@...el.com" <keith.busch@...el.com>
Subject: Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs
 groups


> Hello Christoph,
> 
> How about applying the patch below on top of Hannes' patch? The patch below
> has the advantage that it completely separates the open channel sysfs
> attributes from the NVMe core sysfs attributes - the open channel code
> doesn't have to know anything about the NVMe core sysfs attributes and the
> NVMe core does not have to know anything about the open channel sysfs
> attributes.

This looks better to me Bart (unless I'm missing something)