linux-kernel - Re: [PATCH v2] gpio: brcmstb: allow 0 width GPIO banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a395c600-6d52-a3fb-208c-22c84004a77f@gmail.com>
Date:   Fri, 17 Aug 2018 16:49:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     justinpopo6@...il.com, linux-gpio@...r.kernel.org
Cc:     gregory.0xf0@...il.com, linus.walleij@...aro.org,
        computersforpeace@...il.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: brcmstb: allow 0 width GPIO banks

On 08/17/2018 04:47 PM, justinpopo6@...il.com wrote:
> From: Justin Chen <justinpopo6@...il.com>
> 
> Sometimes we have empty banks within the GPIO block. This commit allows
> proper handling of 0 width GPIO banks. We handle 0 width GPIO banks by
> incrementing the bank and number of GPIOs, but not initializing them.
> This will mean a call into the non-existent GPIOs will return an error.
> 
> Also remove "GPIO registered" dev print. This information is misleading
> since the incremented banks and gpio_base do not reflect the actual GPIOs
> that get initialized. We leave this information out since it is already
> printed with dev_dbg.
> 
> Signed-off-by: Justin Chen <justinpopo6@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks Justin!
--
Florian