linux-kernel - Re: [RFC] etnaviv: missing dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180817064222.GB10811@lst.de>
Date:   Fri, 17 Aug 2018 08:42:22 +0200
From:   Christoph Hellwig <hch@....de>
To:     Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Cc:     linux-snps-arc@...ts.infradead.org,
        Lucas Stach <l.stach@...gutronix.de>,
        Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
        Vineet Gupta <Vineet.Gupta1@...opsys.com>,
        Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
        Russell King <linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [RFC] etnaviv: missing dma_mask

On Tue, Aug 14, 2018 at 05:12:25PM +0300, Eugeniy Paltsev wrote:
> Hi Lucas, Christoph,
> 
> After switching ARC to generic dma_noncoherent cache ops 
> etnaviv driver start failing on dma maping functions because of
> dma_mask lack.
> 
> So I'm wondering is it valid case to have device which is
> DMA capable and doesn't have dma_mask set?
> 
> If not, then I guess something like that should work
> (at least it works for ARC):

This looks ok is a minimal fix:

Reviewed-by: Christoph Hellwig <hch@....de>

But why doesn't this device have a dma-range property in DT?