linux-kernel - Re: [PATCH] staging: rtl8188eu: Type cast function argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B782E3B.7030001@huawei.com>
Date:   Sat, 18 Aug 2018 22:33:31 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Bhaskar Singh <bhaskar.kernel@...il.com>
CC:     <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: rtl8188eu: Type cast function argument

On 2018/8/18 22:24, Bhaskar Singh wrote:
> This patch might suppress some warrning.
>
> The function prototype of rtw_malloc2d is
>
> void *rtw_malloc2d(int h, int w, int size)
>
> This patch also resolves the checkpatch.pl warning
>
> WARNING: line over 80 characters
>
> Signed-off-by: Bhaskar Singh <bhaskar.kernel@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_efuse.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> index 0fd306a808c4..735d654b2844 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> @@ -91,7 +91,8 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8  *pbuf)
>  	if (!efuseTbl)
>  		return;
>  
> -	eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(u16));
> +	eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E,
> +			EFUSE_MAX_WORD_UNIT, (int)sizeof(u16));
>  
  You should be align with left parenthesis.

 Thanks,
 zhong jiang
> 	if (!eFuseWord) {
>  		DBG_88E("%s: alloc eFuseWord fail!\n", __func__);
>  		goto eFuseWord_failed;