linux-kernel - Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e17b3d3-4e5a-7318-e6f6-c8da311e26c8@cogentembedded.com>
Date:   Sat, 18 Aug 2018 19:25:47 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     zhong jiang <zhongjiang@...wei.com>, davem@...emloft.net
Cc:     benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value
 rather than 0

On 08/18/2018 06:53 PM, Sergei Shtylyov wrote:

>> We should use NULL to compare with pointer-typed value rather than
>> 0. The issue is detected with the help of Coccinelle.
> 
>    Your description stopped to match the patch in v2.

  And your subject as well...

>    Actually, this X ==  NULL to !x preference is largely spocific to netdev...

   Specific, of course. :-)

> Although, IDE maintainer is the same now person. :-)  

  "The same person now" I wanted to type. :-)

>  
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
[...]

MBR, Sergei