linux-kernel - Re: [PATCH] gpu: Use ERR_CAST to replace ERR_PTR(PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1568006.WDkDHT9mlz@avalon>
Date:   Sun, 19 Aug 2018 13:49:24 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     tomi.valkeinen@...com, airlied@...ux.ie, sre@...nel.org,
        afd@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: Use ERR_CAST to replace ERR_PTR(PTR_ERR())

Hi Zhong Jiang,

Thank you for the patch.

On Saturday, 18 August 2018 13:57:12 EEST zhong jiang wrote:
> We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
> replace it.
> 
> The issue is detected with the help of Coccinelle
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
> b/drivers/gpu/drm/omapdrm/dss/dss.c index cb80dda..1fc46b2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -956,7 +956,7 @@ struct dss_debugfs_entry *
>  				&dss_debug_fops);
>  	if (IS_ERR(d)) {
>  		kfree(entry);
> -		return ERR_PTR(PTR_ERR(d));
> +		return ERR_CAST(d);
>  	}
> 
>  	entry->dentry = d;

-- 
Regards,

Laurent Pinchart