From 2df79a019776d3aca2436c2b5be6b5b555e641ff Mon Sep 17 00:00:00 2001 From: Amir Goldstein Date: Sun, 19 Aug 2018 13:57:07 +0300 Subject: [PATCH] fsnotify: fix false positive warning on inode delete Reported-by: syzbot+c34692a51b9a6ca93540@syzkaller.appspotmail.com Fixes: 3ac70bfcde81 ("fsnotify: add helper to get mask from connector") Signed-off-by: Amir Goldstein --- fs/notify/mark.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/notify/mark.c b/fs/notify/mark.c index 05506d60131c..d559a8ffe7ed 100644 --- a/fs/notify/mark.c +++ b/fs/notify/mark.c @@ -236,6 +236,13 @@ void fsnotify_put_mark(struct fsnotify_mark *mark) if (hlist_empty(&conn->list)) { inode = fsnotify_detach_connector_from_object(conn); free_conn = true; + } else if (conn->type == FSNOTIFY_OBJ_TYPE_DETACHED) { + /* + * fsnotify_destroy_marks() detaches conn from object before + * put on last mark of object list and other marks on the list + * may still have elevated refcounts. We don't need to recalc + * mask nor to free_conn in that case. + */ } else { __fsnotify_recalc_mask(conn); } -- 2.7.4