linux-kernel - Re: [PATCH] iio: pressure: ms5611: remove deprecated compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Aug 2018 17:16:13 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Tomasz Duszynski <tduszyns@...il.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: pressure: ms5611: remove deprecated compatible
 strings

On Thu, 16 Aug 2018 20:49:15 +0200
Tomasz Duszynski <tduszyns@...il.com> wrote:

> Compatible strings tend to follow manufacturer,model format.
> In case one wants to do a matching with manufacturer stripped
> off he can still do so since SPI/I2C core will try id_table
> based matching anyway.
> 
> Signed-off-by: Tomasz Duszynski <tduszyns@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/pressure/ms5611_i2c.c | 2 --
>  drivers/iio/pressure/ms5611_spi.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5611_i2c.c b/drivers/iio/pressure/ms5611_i2c.c
> index 55fb5fc0b6ea..0469c8ae1134 100644
> --- a/drivers/iio/pressure/ms5611_i2c.c
> +++ b/drivers/iio/pressure/ms5611_i2c.c
> @@ -117,9 +117,7 @@ static int ms5611_i2c_remove(struct i2c_client *client)
>  #if defined(CONFIG_OF)
>  static const struct of_device_id ms5611_i2c_matches[] = {
>  	{ .compatible = "meas,ms5611" },
> -	{ .compatible = "ms5611" },
>  	{ .compatible = "meas,ms5607" },
> -	{ .compatible = "ms5607" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, ms5611_i2c_matches);
> diff --git a/drivers/iio/pressure/ms5611_spi.c b/drivers/iio/pressure/ms5611_spi.c
> index 932e05001e1a..cd11d022208e 100644
> --- a/drivers/iio/pressure/ms5611_spi.c
> +++ b/drivers/iio/pressure/ms5611_spi.c
> @@ -119,9 +119,7 @@ static int ms5611_spi_remove(struct spi_device *spi)
>  #if defined(CONFIG_OF)
>  static const struct of_device_id ms5611_spi_matches[] = {
>  	{ .compatible = "meas,ms5611" },
> -	{ .compatible = "ms5611" },
>  	{ .compatible = "meas,ms5607" },
> -	{ .compatible = "ms5607" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, ms5611_spi_matches);