linux-kernel - Re: [RESEND PATCH] i2c/busses/pasemi: Remove hardcoded bus numbers on smbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180820090718.eb4kgadzg7qevqrx@ninjato>
Date:   Mon, 20 Aug 2018 11:07:18 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Darren Stevens <darren@...vens-zone.net>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RESEND PATCH] i2c/busses/pasemi: Remove hardcoded bus numbers
 on smbus

On Sun, Dec 31, 2017 at 08:53:55PM +0000, Darren Stevens wrote:
> The pasemi smbus controller uses PCI_FUNC(dev->devfn) to define which
> number bus to attach to, however this fails when something else is 
> probed first, for example an ATI Radeon graphics card will claim 9 or
> 10 busses, including the ones the pasemi wants.
> Patch the driver to call i2c_add_adapter rather than
> i2c_add_numbered_adapter.
> 
> Signed-off-by: Darren Stevens <darren@...vens-zone.net>
> 

Applied to for-next, thanks!

Disclaimer: I usually do not like to change the bus numbering because
some people may rely on that. But numbering based on PCI functions seems
really weak and all known users of pasemi seem to have issues here, so I
make an exception.

Thanks to Michael Ellerman for the additional info.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)