linux-kernel - Re: [PATCH 1/2] ip_vti: fix a null pointer deferrence when create vti fallback tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <92EF6630-83A9-4F42-8444-8E67C801208E@cmss.chinamobile.com>
Date:   Mon, 20 Aug 2018 09:58:11 +0800
From:   Haishuang Yan <yanhaishuang@...s.chinamobile.com>
To:     David Miller <davem@...emloft.net>
Cc:     steffen.klassert@...unet.com, kuznet@....inr.ac.ru,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        edumazet@...gle.com
Subject: Re: [PATCH 1/2] ip_vti: fix a null pointer deferrence when create vti
 fallback tunnel



> On 2018年8月20日, at 上午2:27, David Miller <davem@...emloft.net> wrote:
> 
> From: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> Date: Sun, 19 Aug 2018 15:05:04 +0800
> 
>> After set fb_tunnels_only_for_init_net to 1, the itn->fb_tunnel_dev will
>> be NULL and will cause following crash:
> ...
>> Reproduce:
>> echo 1 > /proc/sys/net/core/fb_tunnels_only_for_init_net
>> modprobe ip_vti
>> unshare -n
>> 
>> Fixes: 79134e6ce2c9 (net: do not create fallback tunnels for non-default
>> namespaces)
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> 
> Applied, but please format your Fixes: tag properly next time.
> 
> Do not split up a Fixes tag into multiple lines, no matter how long it
> is.  And enclose the commit header text in both parenthesis and double
> quotes, not just parenthesis.  Like ("blah blah blah"), thank you.
> 

Okay, thanks for reviewing.