linux-kernel - Re: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180820092812.fqu3bbrzar67hmiu@M43218.corp.atmel.com>
Date:   Mon, 20 Aug 2018 11:28:12 +0200
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Barry Song <21cnbao@...il.com>
CC:     <vkoul@...nel.org>, <dan.j.williams@...el.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock
 in tasklet

On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote:
> as you are already in a tasklet, it is unnecessary to call spin_lock_bh.
> 
> Signed-off-by: Barry Song <21cnbao@...il.com>
Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com> 

Thanks
> ---
>  drivers/dma/at_xdmac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 4bf7256..4e55768 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data)
>  		if (atchan->status & AT_XDMAC_CIS_ROIS)
>  			dev_err(chan2dev(&atchan->chan), "request overflow error!!!");
>  
> -		spin_lock_bh(&atchan->lock);
> +		spin_lock(&atchan->lock);
>  		desc = list_first_entry(&atchan->xfers_list,
>  					struct at_xdmac_desc,
>  					xfer_node);
> @@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data)
>  		txd = &desc->tx_dma_desc;
>  
>  		at_xdmac_remove_xfer(atchan, desc);
> -		spin_unlock_bh(&atchan->lock);
> +		spin_unlock(&atchan->lock);
>  
>  		if (!at_xdmac_chan_is_cyclic(atchan)) {
>  			dma_cookie_complete(txd);
> -- 
> 2.7.4
>