linux-kernel - Re: [PATCH] x86/kvm/vmx: Fix coding style in vmx_setup_l1d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4ffd7ca-a508-440e-43eb-34f784e04d3e@redhat.com>
Date:   Mon, 20 Aug 2018 15:03:15 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     rkrcmar@...hat.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, kvm@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, jiang.biao2@....com.cn,
        zhong.weidong@....com.cn
Subject: Re: [PATCH] x86/kvm/vmx: Fix coding style in vmx_setup_l1d_flush()

On 16/08/2018 07:42, Yi Wang wrote:
> Substitute spaces with tab. No functional changes.
> 
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> Reviewed-by: Jiang Biao <jiang.biao2@....com.cn>
> ---
>  arch/x86/kvm/vmx.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 46b428c0..ef712b2 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -218,15 +218,15 @@ static int vmx_setup_l1d_flush(enum vmx_l1d_flush_state l1tf)
>  		return 0;
>  	}
>  
> -       if (boot_cpu_has(X86_FEATURE_ARCH_CAPABILITIES)) {
> -	       u64 msr;
> -
> -	       rdmsrl(MSR_IA32_ARCH_CAPABILITIES, msr);
> -	       if (msr & ARCH_CAP_SKIP_VMENTRY_L1DFLUSH) {
> -		       l1tf_vmx_mitigation = VMENTER_L1D_FLUSH_NOT_REQUIRED;
> -		       return 0;
> -	       }
> -       }
> +	if (boot_cpu_has(X86_FEATURE_ARCH_CAPABILITIES)) {
> +		u64 msr;
> +
> +		rdmsrl(MSR_IA32_ARCH_CAPABILITIES, msr);
> +		if (msr & ARCH_CAP_SKIP_VMENTRY_L1DFLUSH) {
> +			l1tf_vmx_mitigation = VMENTER_L1D_FLUSH_NOT_REQUIRED;
> +			return 0;
> +		}
> +	}
>  
>  	/* If set to auto use the default l1tf mitigation method */
>  	if (l1tf == VMENTER_L1D_FLUSH_AUTO) {
> 

Queued, thanks.

Paolo