linux-kernel - Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Aug 2018 16:17:03 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Bhaskar Singh <bhaskar.kernel@...il.com>
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz

On Mon, Aug 20, 2018 at 06:25:39PM +0530, Bhaskar Singh wrote:
> On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote:
> > On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> > > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
> > 
> > I would be uncomfortable accepting this kind of change without an Ack
> > from the maintainers.
> > 
> > The messes up the indenting so we can accept it anyway.
> > 
> > regards,
> > dan carpenter
> > 
> 
> "find and remove remaining code valid only for 5 HGz. Most of the
> obvious ones have been removed, but things like channel > 14 still
> exist."
> With due respect, I want to say that, the above thing is mention on the
> TODO list, please correct if I intrepreted that statement wrongly.
> 

Yeah.  I think you interpreted it correctly.  That seems fine then.
When I realized that we weren't going to merge the patch then I stopped
reviewing without looking at the TODO.

When you resend the patch, please quote all the relevant information
from the TODO so that we don't have to look for it:

    This patch removes support for channels > 14.  That is from the
    TODO which says:

	- find and remove remaining code valid only for 5 HGz. Most of
	  the obvious ones have been removed, but things like channel >
	  14 still exist.

regards,
dan carpenter