linux-kernel - Re: [PATCH] x86/process: Export start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2852E34-BC10-4161-A05D-981E3A3D4098@amacapital.net>
Date:   Mon, 20 Aug 2018 07:27:11 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Rian Hunter <rian@...m.mit.edu>, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bpetkov@...e.de>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Joerg Roedel <jroedel@...e.de>,
        Dmitry Safonov <dima@...sta.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [PATCH] x86/process: Export start_thread()



> On Aug 20, 2018, at 12:30 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> On Sun, 19 Aug 2018, Andy Lutomirski wrote:
>>> On Aug 19, 2018, at 4:08 PM, Rian Hunter <rian@...m.mit.edu> wrote:
>>> 
>>> Commit e634d8fc792c ("x86-64: merge the standard and compat
>>> start_thread() functions") removed exporting for the start_thread()
>>> function in what seems like a typo. Add it back to
>>> arch/x86/kernel/process_64.c for parity with process_32.c and other
>>> arch.
>> 
>> What for?  Perhaps 32-bit could remove it instead?
> 
> No. start_thread() is called from various binfmt implementations which can
> be built as modules.

Fair enough. I’m fine with the patch.

> 
> Thanks,
> 
>    tglx