linux-kernel - Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Aug 2018 16:52:41 +0200
From:   Jinpu Wang <jinpu.wang@...fitbricks.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable <stable@...r.kernel.org>, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...nel.org>, konrad.wilk@...cle.com,
        Peter Zijlstra <peterz@...radead.org>,
        David Woodhouse <dwmw@...zon.co.uk>
Subject: Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Mon, Aug 20, 2018 at 4:47 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> On Mon, 20 Aug 2018, Jinpu Wang wrote:
> > On Mon, Aug 20, 2018 at 3:02 PM Thomas Gleixner <tglx@...utronix.de> wrote:
> > > That works, but we might as well force 'select HOTPLUG_CPU if SMP' so the
> > > L1TF mitigations are functional. Sigh....
> > >
> > > Thanks,
> > >
> > >         tglx
> > right, sth like?
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index b0312f8..5852948 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -188,7 +188,8 @@ config X86
> >         select HAVE_SYSCALL_TRACEPOINTS
> >         select HAVE_UNSTABLE_SCHED_CLOCK
> >         select HAVE_USER_RETURN_NOTIFIER
> > -       select HOTPLUG_SMT                      if SMP
> > +       select HOTPLUG_CPU                      if SMP
> > +       select HOTPLUG_SMT                      if SMP && HOTPLUG_CPU
>
> The && HOTPLUG is pretty pointless now.
Hmm, so this way?
+       select HOTPLUG_CPU                      if SMP
+       select HOTPLUG_SMT                      if HOTPLUG_CPU

thanks!
-- 
Jack Wang
Linux Kernel Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Tel:       +49 30 577 008  042
Fax:      +49 30 577 008 299
Email:    jinpu.wang@...fitbricks.com
URL:      https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens