linux-kernel - Re: [PATCH 1/2] x86: apm: mark proc_apm_show as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3fF0Xtw_eEbu4oUBMFSWVmMTHUr_=k_CKRWFzi0m370w@mail.gmail.com>
Date:   Mon, 20 Aug 2018 18:11:31 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Al Viro <viro@...iv.linux.org.uk>, Jiri Kosina <jikos@...nel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Christoph Hellwig <hch@....de>, Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] x86: apm: mark proc_apm_show as __maybe_unused

On Mon, Aug 20, 2018 at 5:40 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> On Tue, 14 Aug 2018, Arnd Bergmann wrote:
>
> > A new build error appeared with CONFIG_PROC_FS disabled:
> >
> > arch/x86/kernel/apm_32.c:1643:12: error: 'proc_apm_show' defined but not used [-Werror=unused-function]
> >
> > This marks the function as __maybe_unused to let the compiler drop
> > it silently.
> >
> > Fixes: 3f3942aca6da ("proc: introduce proc_create_single{,_data}")
>
> The proper fix for this is to convert the stub function for proc_apm_show()
> to an inline. The compiler complains because the stub is a macro ....

I even did that
https://patchwork.ozlabs.org/patch/920786/

but then a handful of patches went into the kernel to add #ifdefs
around the other proc_show functions, so it no longer applied.
These two are the only remaining ones.

      Arnd