linux-kernel - Re: [PATCH v1 2/2] Embedded USB Debugger (EUD) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cffb39ab91d2922d5eb06fb9cf388d1f@codeaurora.org>
Date:   Mon, 20 Aug 2018 09:59:10 -0700
From:   pheragu@...eaurora.org
To:     Trilok Soni <tsoni@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        ckadabi@...eaurora.org, bryanh@...eaurora.org,
        psodagud@...eaurora.org, rnayak@...eaurora.org,
        Satya Durga Srinivasu Prabhala <satyap@...eaurora.org>
Subject: Re: [PATCH v1 2/2] Embedded USB Debugger (EUD) driver

On 2018-08-17 12:47, Trilok Soni wrote:
> Hi Prakruthi,
> 
> On 8/16/2018 5:05 PM, Prakruthi Deepak Heragu wrote:
>> +
>> +#define EUD_INT_VBUS		BIT(2)
>> +#define EUD_INT_CHGR		BIT(3)
>> +#define EUD_INT_SAFE_MODE	BIT(4)
>> +
>> +#define EUD_NR			1
> 
> I don't see any use of EUD_NR in the driver below. Do we need it?
Sorry about that. Will get rid of it.