linux-kernel - Re: due to kconfig changes kernel config file is no longer sufficient for configuring the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h6004hokn.wl-tiwai@suse.de>
Date:   Mon, 20 Aug 2018 20:37:12 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Michal Suchánek <msuchanek@...e.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andreas Schwab <schwab@...e.de>,
        Michal Kubecek <mkubecek@...e.cz>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jonathan Corbet <corbet@....net>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Jeff Mahoney <jeffm@...e.com>,
        "Peter Zijlstra," <peterz@...radead.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Nicholas Piggin <npiggin@...il.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        sparclinux <sparclinux@...r.kernel.org>,
        linux-um@...ts.infradead.org
Subject: Re: due to kconfig changes kernel config file is no longer sufficient for configuring the kernel

On Mon, 20 Aug 2018 20:15:12 +0200,
Masahiro Yamada wrote:
> 
> 2018-08-07 3:07 GMT+09:00 Michal Suchánek <msuchanek@...e.de>:
> > On Mon, 30 Jul 2018 17:02:42 +0900
> > Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> >
> >> 2018-06-28 18:16 GMT+09:00 Michal Suchánek <msuchanek@...e.de>:
> >> > On Wed, 27 Jun 2018 23:07:21 +0900
> >> > Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> >> >
> >> >> Hi.
> >> >>
> >> >>
> >> >> 2018-06-27 21:37 GMT+09:00 Michal Suchánek <msuchanek@...e.de>:
> >> >> > Hello,
> >> >> >
> >> >> > in the x86 Kconfig we have this:
> >> >> >
> >> >> > # Select 32 or 64 bit
> >> >> > config 64BIT
> >> >> >         bool "64-bit kernel" if "$(ARCH)" = "x86"
> >> >> >         default "$(ARCH)" != "i386"
> >> >> >         ---help---
> >> >> >           Say yes to build a 64-bit kernel - formerly known as
> >> >> > x86_64 Say no to build a 32-bit kernel - formerly known as i386
> >> >> >
> >> >> > Since commit 104daea149c4 ("kconfig: reference environment
> >> >> > variables directly and remove 'option env='") the value of ARCH
> >> >> > is not saved in the kernel config.
> >> >>
> >> >> I think this commit is unrelated.  It was just a syntax change.
> >> >
> >> > This does not look like syntax only change to me:
> >> >
> >> > diff --git a/init/Kconfig b/init/Kconfig
> >> > index 15aae32e0719..1217fc62ca61 100644
> >> > --- a/init/Kconfig
> >> > +++ b/init/Kconfig
> >> > @@ -1,20 +1,12 @@
> >> > -config ARCH
> >> > -       string
> >> > -       option env="ARCH"
> >> > -
> >> > -config KERNELVERSION
> >> > -       string
> >> > -       option env="KERNELVERSION"
> >> > -
> >>
> >> This is just syntax change.
> >>
> >> 'option env=' was used to reference an environment variable.
> >>
> >> Now, $(ARCH), $(KERNELVERSION) are simpler forms.
> >>
> >>
> >> >>
> >> >> Unless I am missing something,
> >> >> we have never saved ARCH in the .config in the past.
> >> >
> >> > There was a config symbol defined for it before the commit removed
> >> > it.
> >>
> >> No.
> >>
> >> CONFIG symbols with'option env='
> >> are not written out to the .config file.
> >>
> >> We have never had CONFIG_ARCH or CONFIG_KERNELVERSION.

Maybe it sounds like a stupid question, but...
if passing ARCH= is almost mandatory for distinguishing the bi-arch or
cross-compile cases, why don't we save it in .config?

The whole "regression" we've seen can be worked around by passing
ARCH at each time.  So, by having it in .config, everything would work
more easily, no?


thanks,

Takashi