linux-kernel - Re: [PATCH] Raise the minimum required gcc version to 4.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <744af111abe22c4dfda58b4a0759609bcd2eb8f2.camel@perches.com>
Date:   Mon, 20 Aug 2018 13:48:17 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jonathan Corbet <corbet@....net>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Mike Galbraith <efault@....de>,
        Guenter Roeck <linux@...ck-us.net>,
        Rik van Riel <riel@...riel.com>,
        Kees Cook <keescook@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH] Raise the minimum required gcc version to 4.6

On Mon, 2018-08-20 at 14:42 -0600, Jonathan Corbet wrote:
> On Mon, 20 Aug 2018 13:15:26 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
> > +#if GCC_VERSION < 40600
> > +# error Sorry, your compiler is too old - please upgrade it.
> > +#endif
> 
> It seems we could be a little friendlier here?  "Kernel compilation
> requires GCC >= v4.6, please upgrade" ?

This is unchanged text, it's just moved around, but sure, trivial...

Wordsmithing should likely be a separate patch though.
---
 include/linux/compiler-gcc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 250b9b7cfd60..5d95cabd13b3 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -11,7 +11,7 @@
 		     + __GNUC_PATCHLEVEL__)
 
 #if GCC_VERSION < 40600
-# error Sorry, your compiler is too old - please upgrade it.
+# error Kernel compilation requires GCC >= v4.6, please upgrade your compiler
 #endif
 
 /* Optimization barrier */