linux-kernel - Re: [PATCH v2] gpio: brcmstb: allow 0 width GPIO banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8419b0dc-9998-3147-512f-85d2694c6a2e@gmail.com>
Date:   Mon, 20 Aug 2018 14:08:09 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, justinpopo6@...il.com
Cc:     linux-gpio@...r.kernel.org, f.fainelli@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, gregory.0xf0@...il.com,
        computersforpeace@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] gpio: brcmstb: allow 0 width GPIO banks

On 08/17/2018 05:52 PM, Andrew Lunn wrote:
> On Fri, Aug 17, 2018 at 04:47:39PM -0700, justinpopo6@...il.com wrote:
>> From: Justin Chen <justinpopo6@...il.com>
>>
>> Sometimes we have empty banks within the GPIO block. This commit allows
>> proper handling of 0 width GPIO banks.
> 
> Hi Justin
> 
> This is coming from DT? Why do you put 0 width banks in DT in the
> first place?

The way the binding is defined, the "reg" property must cover the entire
GPIO block. On our chips we typically have two blocks, one called GIO
and one called AON_GIO. One of our chips, BCM7429 unfortunately does not
have contiguous banks (groups of 32 GPIOs) within the GIO register
range, it has a first bank from 0 -> 0x20, then nothing, then another
one from 0x40 -> 0x60, which is why this change was proposed, since it
does not break any existing DT blob.
-- 
Florian