lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 21 Aug 2018 08:20:58 +0200
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,, John Ogness <>,
        Sebastian Andrzej Siewior <>,
        Johan Hovold <>
Subject: [PATCH 4.17 26/42] USB: serial: sierra: fix potential deadlock at close

4.17-stable review patch.  If anyone has any objections, please let me know.


From: John Ogness <>

commit e60870012e5a35b1506d7b376fddfb30e9da0b27 upstream.

The portdata spinlock can be taken in interrupt context (via
Disable interrupts when taking the portdata spinlock when discarding
deferred URBs during close to prevent a possible deadlock.

Fixes: 014333f77c0b ("USB: sierra: fix urb and memory leak on disconnect")
Cc: stable <>
Signed-off-by: John Ogness <>
Signed-off-by: Sebastian Andrzej Siewior <>
[ johan: amend commit message and add fixes and stable tags ]
Signed-off-by: Johan Hovold <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/usb/serial/sierra.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -770,9 +770,9 @@ static void sierra_close(struct usb_seri
-		spin_lock(&portdata->lock);
+		spin_lock_irq(&portdata->lock);
-		spin_unlock(&portdata->lock);
+		spin_unlock_irq(&portdata->lock);

Powered by blists - more mailing lists