linux-kernel - Re: [RFC PATCH 4/5] RISC-V: Move interrupt cause declarations to irq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180821074906.GB28079@infradead.org>
Date:   Tue, 21 Aug 2018 00:49:06 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Atish Patra <atish.patra@....com>
Cc:     palmer@...ive.com, linux-riscv@...ts.infradead.org,
        mark.rutland@....com, anup@...infault.org, hch@...radead.org,
        tglx@...utronix.de, Damien.LeMoal@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/5] RISC-V: Move interrupt cause declarations to
 irq.h

On Wed, Aug 15, 2018 at 04:56:16PM -0700, Atish Patra wrote:
> CPU hotplug code in smpboot requires interrupt cause
> to identify the cause of cpu wakeup.
> 
> Move the IRQ cause declarations to appropriate header
> file.

asm/irq.h is a header indirectly included by just about every
driver.  This is a very bad place for such internal definitions.