linux-kernel - Re: [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180821023840.GD20263@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 20 Aug 2018 19:38:40 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     Chao Yu <yuchao0@...wei.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] f2fs: fix to avoid quota inode leak in ->put_super

On 08/20, Chao Yu wrote:
> On 2018/8/18 23:16, Jaegeuk Kim wrote:
> > On 08/17, Chao Yu wrote:
> >> generic/019 reports below error:
> >>
> >>  __quota_error: 1160 callbacks suppressed
> >>  Quota error (device zram1): write_blk: dquota write failed
> >>  Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >>  Quota error (device zram1): write_blk: dquota write failed
> >>  Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >>  Quota error (device zram1): write_blk: dquota write failed
> >>  Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >>  Quota error (device zram1): write_blk: dquota write failed
> >>  Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >>  Quota error (device zram1): write_blk: dquota write failed
> >>  Quota error (device zram1): qtree_write_dquot: Error -28 occurred while creating quota
> >>  VFS: Busy inodes after unmount of zram1. Self-destruct in 5 seconds.  Have a nice day...
> >>
> >> If we failed in below path due to fail to write dquot block, we will miss
> >> to release quota inode, fix it.
> >>
> >> - f2fs_put_super
> >>  - f2fs_quota_off_umount
> >>   - f2fs_quota_off
> >>    - f2fs_quota_sync   <-- failed
> >>    - dquot_quota_off   <-- missed to call
> >>
> >> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> >> ---
> >>  fs/f2fs/super.c | 6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> >> index a5df9fbc6355..9647bbcdfd2b 100644
> >> --- a/fs/f2fs/super.c
> >> +++ b/fs/f2fs/super.c
> >> @@ -1977,10 +1977,12 @@ void f2fs_quota_off_umount(struct super_block *sb)
> >>  	for (type = 0; type < MAXQUOTAS; type++) {
> >>  		err = f2fs_quota_off(sb, type);
> >>  		if (err) {
> >> +			int ret = dquot_quota_off(sb, type);
> >> +
> > 
> > Could you check the mainline version?
> 
> I guess we missed to apply below patch? Could you check that?
> 
> f2fs: report error if quota off error during umount

I remember there was a bug in the patch.

> 
> Thanks,
> 
> > 
> >>  			f2fs_msg(sb, KERN_ERR,
> >>  				"Fail to turn off disk quota "
> >> -				"(type: %d, err: %d), Please "
> >> -				"run fsck to fix it.", type, err);
> >> +				"(type: %d, err: %d, ret:%d), Please "
> >> +				"run fsck to fix it.", type, err, ret);
> >>  			set_sbi_flag(F2FS_SB(sb), SBI_NEED_FSCK);
> >>  		}
> >>  	}
> >> -- 
> >> 2.18.0.rc1