lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Aug 2018 15:04:30 +0200 From: Borislav Petkov <bp@...en8.de> To: Paolo Bonzini <pbonzini@...hat.com> Cc: Pu Wen <puwen@...on.cn>, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com, x86@...nel.org, thomas.lendacky@....com, mchehab@...nel.org, mikhail.jin@...il.com, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, linux-edac@...r.kernel.org Subject: Re: [PATCH v4 15/16] driver/edac: enable Hygon support to AMD64 EDAC driver On Tue, Aug 21, 2018 at 01:26:13PM +0200, Paolo Bonzini wrote: > But then I don't see the point of adding the Hygon vendor, since any > check can be simplified: I think Hygon wanted to superficially show it is not really an AMD. For example, the Hygon thing doesn't do SME/SEV. AFAIK. So we can just as well check only family but I'd say the vendor thing is laying the grounds for the future where reportedly it will differ more from an AMD. And then we can start splitting code more based on vendor and not look at family at all. But for right now I think we should strive to keep the changes as small as possible and only do real splitting when they start adding new functionality. Which would mean having a hygon_edac.c too, for example. All, IMHO, of course. Sharing code between vendors is always yucky. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --
Powered by blists - more mailing lists