lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Aug 2018 18:46:52 +0200 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Taeung Song <treeze.taeung@...il.com> Cc: Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, Linux Netdev List <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] libbpf: Remove the duplicate checking of function storage On Tue, Aug 21, 2018 at 6:12 PM, Taeung Song <treeze.taeung@...il.com> wrote: > After the commit eac7d84519a3 ("tools: libbpf: don't return '.text' > as a program for multi-function programs"), bpf_program__next() > in bpf_object__for_each_program skips the function storage such as .text, > so eliminate the duplicate checking. > > Cc: Jakub Kicinski <jakub.kicinski@...ronome.com> > Signed-off-by: Taeung Song <treeze.taeung@...il.com> Looks reasonable, but you may need to repost once bpf-next is open: https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com> > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 2abd0f112627..8476da7f2720 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -2336,7 +2336,7 @@ int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr, > bpf_program__set_expected_attach_type(prog, > expected_attach_type); > > - if (!bpf_program__is_function_storage(prog, obj) && !first_prog) > + if (!first_prog) > first_prog = prog; > } > > -- > 2.17.1 >
Powered by blists - more mailing lists