lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 21 Aug 2018 10:00:34 -0700
From:   Paul Burton <>
To:     Masahiro Yamada <>
Cc:     Linux-MIPS <>,
        linux-arch <>,
        Arnd Bergmann <>, James Hogan <>,
        Linux Kbuild mailing list <>,
        Linux Kernel Mailing List <>,
        Ralf Baechle <>
Subject: Re: [PATCH v9 1/2] kbuild: Allow arch-specific asm/compiler.h

Hi Masahiro,

On Tue, Aug 21, 2018 at 11:49:48AM +0900, Masahiro Yamada wrote:
> The code diff looks good to me.
> Reviewed-by: Masahiro Yamada <>

Thanks :)

> > A straightforward approach to the per-arch header is to make use of
> > asm-generic to provide a default empty header & adjust architectures
> > which don't need anything specific to make use of that by adding the
> > header to generic-y. Unfortunately this doesn't work so well due to
> > commit a95b37e20db9 ("kbuild: get <linux/compiler_types.h> out of
> > <linux/kconfig.h>") which moved the inclusion of linux/compiler.h to
> > cflags using the -include compiler flag.
> I doubt this statement.
> Commit a95b37e20db9 is not the cause of the problem.
> The change happened in commit 28128c61e08e.

You're correct - I'll fix that up.

> One more thing, you are not touching any makefile in this version.
> Maybe, you can prefix the subject with "compiler.h:" or something
> instead of "kbuild:".

Will do.


Powered by blists - more mailing lists