linux-kernel - Re: [PATCH] block/DAC960.c: make some arrays static const, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cbe876ce-8f1f-1dc3-86fb-b26278277312@kernel.dk>
Date:   Tue, 21 Aug 2018 11:00:49 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Colin King <colin.king@...onical.com>, linux-block@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block/DAC960.c: make some arrays static const, shrinks
 object size

On 8/21/18 3:12 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the arrays ReadCacheStatus, WriteCacheStatus and
> SenseErrors on the stack but instead make them static const. Makes
> the object code smaller by 47 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>  160974	  34628	    832	 196434	  2ff52	drivers/block/DAC960.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>  160671	  34884	    832	 196387	  2ff23	drivers/block/DAC960.o
> 
> (gcc version 8.2.0 x86_64)

Applied, thanks.

-- 
Jens Axboe