linux-kernel - Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1808231239470.3596@grey.csi.cam.ac.uk>
Date:   Thu, 23 Aug 2018 12:42:38 +0100
From:   Tony Finch <dot@...at.at>
To:     Harshit Jain <harshitjain6751@...il.com>
cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

Harshit Jain <harshitjain6751@...il.com> wrote:

> Hey! tony thanks for reviewing, pardon me i wasn't able to get your context
> can you please elaborate a little what you are trying to say?

There's a big block comment above the state machine code which tries to
explain what the blazes is going on. The comment includes an explanation
of the weird strncpy() call, which you need to update to talk about
memcpy() instead.

(The code is heavily compactified because I wrote it on a laptop with a
small screen and I needed to be able to see it all to understand it!)

Tony.
-- 
f.anthony.n.finch  <dot@...at.at>  http://dotat.at/
South Fitzroy: Northerly or northeasterly 5 or 6. Slight or moderate.
Occasional drizzle. Good, occasionally poor at first.