linux-kernel - Re: [PATCH 1/5] drm/nouveau: Check backlight IDs are >= 0, not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACO55tsuJUyQULA3oGm9VxH7ufObvW1bNH_1g7WCwcpJPrVugw@mail.gmail.com>
Date:   Thu, 23 Aug 2018 14:00:25 +0200
From:   Karol Herbst <kherbst@...hat.com>
To:     Lyude Paul <lyude@...hat.com>
Cc:     nouveau <nouveau@...ts.freedesktop.org>, stable@...r.kernel.org,
        Jeffery Miller <jmiller@...erware.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] drm/nouveau: Check backlight IDs are >= 0, not > 0

Patches 1-5 are Reviewed-by: Karol Herbst <kherbst@...hat.com>

I think it might be worth to test those patches on a system without
any backlight devices just to verify we don't break things, but the
code looked good already, so maybe we don't really need to test.

On Thu, Aug 23, 2018 at 3:21 AM, Lyude Paul <lyude@...hat.com> wrote:
> Remember, ida IDs start at 0, not 1!
>
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: stable@...r.kernel.org
> Cc: Jeffery Miller <jmiller@...erware.com>
> Cc: Karol Herbst <kherbst@...hat.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
> index 408b955e5c39..6dd72bc32897 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
> @@ -116,7 +116,7 @@ nv40_backlight_init(struct drm_connector *connector)
>                                        &nv40_bl_ops, &props);
>
>         if (IS_ERR(bd)) {
> -               if (bl_connector.id > 0)
> +               if (bl_connector.id >= 0)
>                         ida_simple_remove(&bl_ida, bl_connector.id);
>                 return PTR_ERR(bd);
>         }
> @@ -249,7 +249,7 @@ nv50_backlight_init(struct drm_connector *connector)
>                                        nv_encoder, ops, &props);
>
>         if (IS_ERR(bd)) {
> -               if (bl_connector.id > 0)
> +               if (bl_connector.id >= 0)
>                         ida_simple_remove(&bl_ida, bl_connector.id);
>                 return PTR_ERR(bd);
>         }
> --
> 2.17.1
>