linux-kernel - Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb54216e-ee75-a816-8316-b385a2cdd576@redhat.com>
Date:   Thu, 23 Aug 2018 18:26:40 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Jim Mattson <jmattson@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of
 nested_run_pending

On 23/08/2018 18:24, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
>  arch/x86/kvm/vmx.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
>  	    check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
>  		return -EINVAL;
>  
> -	if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> -		vmx->nested.nested_run_pending = 1;
> -
>  	vmx->nested.dirty_vmcs12 = true;
>  	ret = enter_vmx_non_root_mode(vcpu, NULL);
>  	if (ret)
> 

Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>