linux-kernel - [PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61369202-8425-4cb7-aa9d-b83f15c528e0@infradead.org>
Date:   Thu, 23 Aug 2018 10:52:39 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     "H. Nikolaus Schaller" <hns@...delico.com>,
        Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
        Lucas De Marchi <lucas.de.marchi@...il.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jessica Yu <jeyu@...nel.org>,
        Chih-Wei Huang <cwhuang@...ux.org.tw>,
        stable <stable@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>,
        linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: [PATCH v2] modules_install: make missing $DEPMOD a warning instead of
 error

From: Randy Dunlap <rdunlap@...radead.org>

When $DEPMOD is not found, only print a warning instead of exiting
with an error message and error status.

Warning: 'make modules_install' requires /sbin/depmod. Please install it.
This is probably in the kmod package.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
---
v2: add missing "exit 0" and update the commit message (no Error).

 scripts/depmod.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- lnx-418.orig/scripts/depmod.sh
+++ lnx-418/scripts/depmod.sh
@@ -15,9 +15,9 @@ if ! test -r System.map ; then
 fi
 
 if [ -z $(command -v $DEPMOD) ]; then
-	echo "'make modules_install' requires $DEPMOD. Please install it." >&2
+	echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
 	echo "This is probably in the kmod package." >&2
-	exit 1
+	exit 0
 fi
 
 # older versions of depmod require the version string to start with three