linux-kernel - Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8A695D99-A693-4E81-A321-4DC599A8F36A@goldelico.com>
Date:   Thu, 23 Aug 2018 21:38:51 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable <stable@...r.kernel.org>,
        Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
        Lucas De Marchi <lucas.de.marchi@...il.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jessica Yu <jeyu@...nel.org>,
        Chih-Wei Huang <cwhuang@...ux.org.tw>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>
Subject: Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

Hi Randy,

> Am 23.08.2018 um 20:13 schrieb Randy Dunlap <rdunlap@...radead.org>:
> 
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> When $DEPMOD is not found, only print a warning instead of exiting
> with an error message and error status.
> 
> Warning: 'make modules_install' requires /sbin/depmod. Please install it.
> This is probably in the kmod package.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD is installed")
> Cc: stable@...r.kernel.org
> Cc: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
> Cc: Lucas De Marchi <lucas.de.marchi@...il.com>
> Cc: Michal Marek <michal.lkml@...kovi.net>
> Cc: Jessica Yu <jeyu@...nel.org>
> Cc: Chih-Wei Huang <cwhuang@...ux.org.tw>
> Cc: H. Nikolaus Schaller <hns@...delico.com>
> ---
> v2: add missing "exit 0" and update the commit message (no Error).
> v3: add Fixes: and Cc: stable
> 
> scripts/depmod.sh |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- lnx-418.orig/scripts/depmod.sh
> +++ lnx-418/scripts/depmod.sh
> @@ -15,9 +15,9 @@ if ! test -r System.map ; then
> fi
> 
> if [ -z $(command -v $DEPMOD) ]; then
> -	echo "'make modules_install' requires $DEPMOD. Please install it." >&2
> +	echo "Warning: 'make modules_install' requires $DEPMOD. Please install it." >&2
> 	echo "This is probably in the kmod package." >&2
> -	exit 1
> +	exit 0
> fi
> 
> # older versions of depmod require the version string to start with three
> 

works for me.

  INSTALL sound/usb/snd-usb-audio.ko - due to target is PHONY
  INSTALL sound/usb/snd-usbmidi-lib.ko - due to target is PHONY
  DEPMOD  4.18.4-letux+ - due to target is PHONY
Warning: 'make modules_install' requires /sbin/depmod. Please install it.
This is probably in the kmod package.

and returns success status.

BR and thanks,
Nikolaus Schaller