linux-kernel - Re: [PATCH] fs/ocfs2/dlmglue: lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWCyH-E9VA7ihsoXEq4dvLrPjYd01TYot6qja-psVRcog@mail.gmail.com>
Date:   Thu, 23 Aug 2018 23:07:02 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     anders.roxell@...aro.org
Cc:     mark@...heh.com, Joel Becker <jlbec@...lplan.org>,
        ocfs2-devel@....oracle.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/ocfs2/dlmglue: lockdep_keys defined but not used

Hi Anders,

On Wed, Jul 4, 2018 at 11:54 AM Anders Roxell <anders.roxell@...aro.org> wrote:
> When CONFIG_DEBUG_LOCK_ALLOC isn't enabled lockdep_keys isn't used and
> we get a warning:
> fs/ocfs2/dlmglue.c:99:30: warning: ‘lockdep_keys’ defined but not used
>     [-Wunused-variable]
>  static struct lock_class_key lockdep_keys[OCFS2_NUM_LOCK_TYPES];
>                               ^~~~~~~~~~~~
> Adding __maybe_unused to the declaration hids the warning.

Thanks for your patcj!

> Fixes: 1cd75cdb8fbb ("ocfs2: make several functions and variables static (and some const)")

Fixes: 480bd56485b77c36 ("ocfs2: make several functions and variables
static (and some const)")

Presumably the branch got rebased?

> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds