linux-kernel - [PATCH] scsi: qla1280: Fix memory leak when open DUMP_IT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 23 Aug 2018 05:19:03 -0400
From:   Ding Xiang <dingxiang@...s.chinamobile.com>
To:     mdr@....com, jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: qla1280: Fix memory leak when open DUMP_IT_BACK

If open DUMP_IT_BACK and unfortunately fw is error, memory leak
will happen.

Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
---
 drivers/scsi/qla1280.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 390775d..abdcf70 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -1756,8 +1756,12 @@ static void qla1280_mailbox_timeout(struct timer_list *t)
 #endif
 
 	fw = qla1280_request_firmware(ha);
-	if (IS_ERR(fw))
+	if (IS_ERR(fw)) {
+#if DUMP_IT_BACK
+		pci_free_consistent(ha->pdev, 8000, tbuf, p_tbuf);
+#endif
 		return PTR_ERR(fw);
+	}
 
 	fw_data = (const __le16 *)&fw->data[0];
 	ha->fwstart = __le16_to_cpu(fw_data[2]);
-- 
1.8.3.1