linux-kernel - Re: [PATCH] ACPI: fix menuconfig presentation of ACPI submenu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gaWhTZFL+MP1D9tGsPAe0R6cqH1RiEjQ37mXE4P7g5Ng@mail.gmail.com>
Date:   Thu, 23 Aug 2018 10:23:17 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Will Deacon <will.deacon@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: fix menuconfig presentation of ACPI submenu

On Tue, Aug 21, 2018 at 10:38 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> My fix for a recursive Kconfig dependency caused another issue where the
> ACPI specific options end up in the top-level menu in 'menuconfig'. This
> was an unintended side-effect of having a silent option between
> 'menuconfig ACPI' and 'if ACPI'.
>
> Moving the ARCH_SUPPORTS_ACPI symbol ahead of the ACPI menu solves that
> problem and restores the previous presentation.
>
> Reported-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Fixes: 2c870e61132c ("arm64: fix ACPI dependencies")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks!

I'll push this to Linus tomorrow.

> ---
>  drivers/acpi/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 1edca05ee0ae..e92eab1e960c 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -3,6 +3,9 @@
>  # ACPI Configuration
>  #
>
> +config ARCH_SUPPORTS_ACPI
> +       bool
> +
>  menuconfig ACPI
>         bool "ACPI (Advanced Configuration and Power Interface) Support"
>         depends on ARCH_SUPPORTS_ACPI
> @@ -40,9 +43,6 @@ menuconfig ACPI
>           <http://www.acpi.info>
>           <http://www.uefi.org/acpi/specs>
>
> -config ARCH_SUPPORTS_ACPI
> -       bool
> -
>  if ACPI
>
>  config ACPI_LEGACY_TABLES_LOOKUP
> --
> 2.18.0
>