[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-id: <1535013819-1646-1-git-send-email-huijin.park@samsung.com>
Date: Thu, 23 Aug 2018 04:43:39 -0400
From: Huijin Park <huijin.park@...sung.com>
To: Boris Brezillon <boris.brezillon@...tlin.com>
Cc: Marek Vasut <marek.vasut@...il.com>, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org,
Huijin Park <huijin.park@...sung.com>, bbanghj.park@...il.com
Subject: [PATCH] mtd: change len type from signed to unsigned type
From: "huijin.park" <huijin.park@...sung.com>
assign of a signed value which has type 'int' to a variable of
a bigger unsigned integer type 'uint64_t'.
this is ok most of the time, but can lead to unexpectedly large
resulting value if the original signed value is negative.
in addtion, the callers of the erase_write() pass the len parameter
as unsigned type.
Signed-off-by: huijin.park <huijin.park@...sung.com>
---
drivers/mtd/mtdblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index a5b1933..b2d5ed1 100644
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -56,7 +56,7 @@ struct mtdblk_dev {
*/
static int erase_write (struct mtd_info *mtd, unsigned long pos,
- int len, const char *buf)
+ unsigned int len, const char *buf)
{
struct erase_info erase;
size_t retlen;
--
1.7.9.5
Powered by blists - more mailing lists