linux-kernel - Re: [PATCH v3] EDAC, amd64: Add Family 17h Model 10h support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO6F7Dmw2OKWPRkq_N-Gd+5FSL+7WYaBsgMHZJT_O-y-ee7z4w@mail.gmail.com>
Date:   Thu, 23 Aug 2018 06:27:09 -0400
From:   Michael Jin <mikhail.jin@...il.com>
To:     Borislav Petkov <bp@...e.de>,
        Yazen Ghannam <Yazen.Ghannam@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michael Jin <mikhail.jin@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH v3] EDAC, amd64: Add Family 17h Model 10h support.

On Thu, Aug 16, 2018 at 2:17 PM, Ghannam, Yazen <Yazen.Ghannam@....com> wrote:
>> -----Original Message-----
>> From: Michael Jin <mikhail.jin@...il.com>
>> Sent: Wednesday, August 15, 2018 6:41 AM
>> To: Borislav Petkov <bp@...e.de>; Ghannam, Yazen
>> <Yazen.Ghannam@....com>; Mauro Carvalho Chehab
>> <mchehab@...nel.org>
>> Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; Michael Jin
>> <mikhail.jin@...il.com>; stable@...r.kernel.org
>> Subject: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support.
>>
>> Add support for ECC error decoding on family 17h models 10h-2fh.
>>
>
> Can you please make this more specific? Something like "Add PCI device IDs
> for Fam17h Models 10h-2Fh so that amd64_edac_mod will load".
>
>> Link: https://lkml.kernel.org/r/20180810193623.24629-1-
>> mikhail.jin@...il.com
>> Cc: stable@...r.kernel.org
>
> This won't apply to all stable branches. EDAC support for Fam17h was added
> in v4.10.
>
> I'm not sure if the stable tag needs to be modified, or if the stable queues
> automatically drop patches that don't apply.
>
>> Signed-off-by: Michael Jin <mikhail.jin@...il.com>
>> ---
>>  drivers/edac/amd64_edac.c | 15 +++++++++++++++
>>  drivers/edac/amd64_edac.h |  3 +++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
>> index 18aeabb1d5ee..2d7b6d37d6ec 100644
>> --- a/drivers/edac/amd64_edac.c
>> +++ b/drivers/edac/amd64_edac.c
>> @@ -3188,6 +3197,12 @@ static struct amd64_family_type
>> *per_family_init(struct amd64_pvt *pvt)
>>               break;
>>
>>       case 0x17:
>> +             /* Check if CPU model is in range 10h-2fh */
>
> This comment is not needed because it's obvious from the code.
>
>
> Other than those few nits this looks good to me.
>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>
>
> Thanks,
> Yazen

This version of the patch includes tweaks suggested by Yazen in his
review for patch v2 (Link:
https://lkml.kernel.org/r/BN7PR12MB2593B097267132250140FBEAF83E0@BN7PR12MB2593.namprd12.prod.outlook.com).

Does anyone else have any feedback for this patch I submitted a week ago?

Thanks,
Michael