[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5B7E9774.7010500@huawei.com>
Date: Thu, 23 Aug 2018 19:16:04 +0800
From: zhong jiang <zhongjiang@...wei.com>
To: Colin King <colin.king@...onical.com>
CC: Linus Walleij <linus.walleij@...aro.org>,
Eric Anholt <eric@...olt.net>, David Airlie <airlied@...ux.ie>,
<dri-devel@...ts.freedesktop.org>,
<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/pl111: add in missing sentinel to a of_device_id
array
Hi, Colin
I has posted the same patch about a month ago. but it seems to be ignored.:-(
https://lore.kernel.org/patchwork/patch/971652/
Thanks,
zhong jiang
On 2018/8/21 18:54, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Array vexpress_muxfpga_match is missing an end of array sentinel,
> add it.
>
> Detected by Coccinelle: ("vexpress_muxfpga_match is not NULL
> terminated at line")
>
> Fixes: ca454bd42dc2 ("drm/pl111: Support the Versatile Express")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/gpu/drm/pl111/pl111_vexpress.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c
> index a534b225e31b..48e2afcd4798 100644
> --- a/drivers/gpu/drm/pl111/pl111_vexpress.c
> +++ b/drivers/gpu/drm/pl111/pl111_vexpress.c
> @@ -111,7 +111,8 @@ static int vexpress_muxfpga_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id vexpress_muxfpga_match[] = {
> - { .compatible = "arm,vexpress-muxfpga", }
> + { .compatible = "arm,vexpress-muxfpga", },
> + { /* sentinel */ }
> };
>
> static struct platform_driver vexpress_muxfpga_driver = {
Powered by blists - more mailing lists