linux-kernel - RE: [PATCH V4 3/3] Input: new da7280 haptic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR10MB216980706A65A8E913A1BE7285360@DB7PR10MB2169.EURPRD10.PROD.OUTLOOK.COM>
Date:   Fri, 24 Aug 2018 05:35:54 +0000
From:   Roy Im <roy.im.opensource@...semi.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Roy Im <roy.im.opensource@...semi.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>
CC:     Mark Rutland <mark.rutland@....com>,
        Support Opensource <Support.Opensource@...semi.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V4 3/3] Input: new da7280 haptic driver

Hi Randy,

On 08/24/2018 12:28 AM, Randy Dunlap wrote:

> On 08/20/2018 10:44 PM, Roy Im wrote:
> > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> > index ca59a2b..6e0de69 100644
> > --- a/drivers/input/misc/Kconfig
> > +++ b/drivers/input/misc/Kconfig
> > @@ -851,4 +851,16 @@ config INPUT_SC27XX_VIBRA
> >  	  To compile this driver as a module, choose M here. The module
> will
> >  	  be called sc27xx_vibra.
> >
> 
> Hi,
> Can you explain the "depends on" below, please.
> 
> > +config INPUT_DA7280_HAPTICS
> > +	tristate "Dialog Semiconductor DA7280 haptics support"
> > +	depends on (INPUT && I2C && SYSFS) || PWM
> > +	select INPUT_FF_MEMLESS
> > +	select REGMAP_I2C
> 
> If INPUT is disabled, and I2C is disabled, and SYSFS is disabled, but
> PWM=y,
> then the "select"s will have problems with unmet dependencies.

I will fix this in v5.

> 
> > +	help
> > +	  Say Y to enable support for the haptics controller on
> > +	  Dialog DA7280 chip.
> > +
> > +	  To compile this driver as a module, choose M here: the
> > +	  module will be called da7280-haptic.
> 
> That module name doesn't match what's in the Makefile (below).

I will fix this as well in v5.

> 
> > +
> >  endif
> > diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
> > index 9d0f9d1..d941348 100644
> > --- a/drivers/input/misc/Makefile
> > +++ b/drivers/input/misc/Makefile
> > @@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000)		+=
> cma3000_d0x.o
> >  obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
> >  obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
> >  obj-$(CONFIG_INPUT_CPCAP_PWRBUTTON)	+= cpcap-pwrbutton.o
> > +obj-$(CONFIG_INPUT_DA7280_HAPTICS)	+= da7280.o
> >  obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
> >  obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
> >  obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
> 
> 
> --
> ~Randy

Regards,
Roy