linux-kernel - RE: [PATCH] thermal: of-thermal: disable passive polling when thermal zone is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB39168BB2C854A55401D4C648F5360@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Fri, 24 Aug 2018 07:10:13 +0000
From:   Anson Huang <anson.huang@....com>
To:     "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "edubezval@...il.com" <edubezval@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>, Nitin Garg <nitin.garg@....com>
Subject: RE: [PATCH] thermal: of-thermal: disable passive polling when thermal
 zone is disabled

Gentle Ping...

Anson Huang
Best Regards!


> -----Original Message-----
> From: Anson Huang
> Sent: Tuesday, July 31, 2018 12:57 AM
> To: rui.zhang@...el.com; edubezval@...il.com; linux-pm@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Cc: dl-linux-imx <linux-imx@....com>; Nitin Garg <nitin.garg@....com>
> Subject: [PATCH] thermal: of-thermal: disable passive polling when thermal
> zone is disabled
> 
> When thermal zone is in passive mode, disabling its mode from sysfs is NOT
> taking effect at all, it is still polling the temperature of the disabled thermal
> zone and handling all thermal trips, it makes user confused. The disabling
> operation should disable the thermal zone behavior completely, for both active
> and passive mode, this patch clears the passive_delay when thermal zone is
> disabled and restores it when it is enabled.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>  drivers/thermal/of-thermal.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index
> 977a830..4f28165 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -260,10 +260,13 @@ static int of_thermal_set_mode(struct
> thermal_zone_device *tz,
> 
>  	mutex_lock(&tz->lock);
> 
> -	if (mode == THERMAL_DEVICE_ENABLED)
> +	if (mode == THERMAL_DEVICE_ENABLED) {
>  		tz->polling_delay = data->polling_delay;
> -	else
> +		tz->passive_delay = data->passive_delay;
> +	} else {
>  		tz->polling_delay = 0;
> +		tz->passive_delay = 0;
> +	}
> 
>  	mutex_unlock(&tz->lock);
> 
> --
> 2.7.4