[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180824131026.GB11868@brain-police>
Date: Fri, 24 Aug 2018 14:10:27 +0100
From: Will Deacon <will.deacon@....com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Nicholas Piggin <npiggin@...il.com>,
Peter Zijlstra <peterz@...radead.org>,
torvalds@...ux-foundation.org, luto@...nel.org, x86@...nel.org,
bp@...en8.de, riel@...riel.com, jannh@...gle.com,
ascannell@...gle.com, dave.hansen@...el.com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
David Miller <davem@...emloft.net>,
Martin Schwidefsky <schwidefsky@...ibm.com>,
Michael Ellerman <mpe@...erman.id.au>,
linux-arch@...r.kernel.org, Palmer Dabbelt <palmer@...ive.com>,
linux-riscv@...ts.infradead.org
Subject: Re: [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build
failures)
On Fri, Aug 24, 2018 at 06:07:22AM -0700, Guenter Roeck wrote:
> On Thu, Aug 23, 2018 at 06:47:09PM +1000, Nicholas Piggin wrote:
> > The generic tlb_end_vma does not call invalidate_range mmu notifier,
> > and it resets resets the mmu_gather range, which means the notifier
> > won't be called on part of the range in case of an unmap that spans
> > multiple vmas.
> >
> > ARM64 seems to be the only arch I could see that has notifiers and
> > uses the generic tlb_end_vma. I have not actually tested it.
> >
> > Signed-off-by: Nicholas Piggin <npiggin@...il.com>
> > Acked-by: Will Deacon <will.deacon@....com>
>
> This patch breaks riscv builds in mainline.
Looks very similar to the breakage we hit on arm64. diff below should fix
it.
Will
--->*
diff --git a/arch/riscv/include/asm/tlb.h b/arch/riscv/include/asm/tlb.h
index c229509288ea..5017060be63c 100644
--- a/arch/riscv/include/asm/tlb.h
+++ b/arch/riscv/include/asm/tlb.h
@@ -14,11 +14,11 @@
#ifndef _ASM_RISCV_TLB_H
#define _ASM_RISCV_TLB_H
-#include <asm-generic/tlb.h>
-
static inline void tlb_flush(struct mmu_gather *tlb)
{
flush_tlb_mm(tlb->mm);
}
+#include <asm-generic/tlb.h>
+
#endif /* _ASM_RISCV_TLB_H */
Powered by blists - more mailing lists