linux-kernel - Re: [PATCH v2 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <022159d88ada0092f5c24a0881e2375d@codeaurora.org>
Date:   Fri, 24 Aug 2018 10:58:19 -0700
From:   vnkgutta@...eaurora.org
To:     Evan Green <evgreen@...omium.org>
Cc:     robh@...nel.org, mchehab@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, tsoni@...eaurora.org,
        ckadabi@...eaurora.org, rishabhb@...eaurora.org, bp@...en8.de
Subject: Re: [PATCH v2 1/4] drivers: soc: Add broadcast base for Last Level
 Cache Controller (LLCC)

On 2018-08-23 16:01, Evan Green wrote:
> On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta
> <vnkgutta@...eaurora.org> wrote:
>> 
>> Currently, boradcast base is set to end of the LLCC banks, which may
> 
> s/boradcast/broadcast/

I'll correct this typo in the next version.

> 
>> not be correct always. As the number of banks may vary for each 
>> chipset
>> and the broadcast base could be at a different address as well. This 
>> info
>> depends on the chipset, so get the broadcast base info from the device
>> tree (DT). Add broadcast base in LLCC driver and use this for 
>> broadcast
>> writes.
>> 
>> Signed-off-by: Venkata Narendra Kumar Gutta <vnkgutta@...eaurora.org>
>> ---
>>  drivers/soc/qcom/llcc-slice.c      | 55 
>> +++++++++++++++++++++++---------------
>>  include/linux/soc/qcom/llcc-qcom.h |  4 +--
>>  2 files changed, 35 insertions(+), 24 deletions(-)
>> 
> 
> Reviewed-by: Evan Green <evgreen@...omium.org>